Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Track collection events #2256

Open
wants to merge 11 commits into
base: public-collections-feature
Choose a base branch
from
Open

feat: Track collection events #2256

wants to merge 11 commits into from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Dec 18, 2024 •
edited
Loading

Resolves #2224

Changes

  • Renames inject_analytics to inject_extra and updates docs
  • Manually tracks page views to enable passing custom props
  • Tracks copying collection share link and downloading a public collection

Manual testing

  1. Add INJECT_ANALYTICS to .env.local to match dev Helm chart value
  2. Add ANALYTICS_NAMESPACE=plausible to your .env.local
  3. Log in to org with public collections
  4. Go to public collection
  5. Click "Copy Link"
  6. Log in to Plausible
  7. Go to dev dashboard. Verify [Collections] Copy share collection link goal is logged
  8. Paste in copied link
  9. Go to Plausible dashboard. Verify [Collections] View public collection goal is logged
  10. Go back to collection and click download
  11. Go to Plausible dashboard. Verify [Collections] Download public collection goal is logged

@SuaYoo SuaYoo changed the base branch from main to frontend-thumbnails-start-page December 18, 2024 06:12
Base automatically changed from frontend-thumbnails-start-page to public-collections-feature December 23, 2024 20:38
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from ff11634 to 6f2d7bb Compare December 23, 2024 20:39
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page--tracking branch from a8f54c6 to b27218d Compare December 23, 2024 20:40
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from 6f2d7bb to 8cfd49d Compare January 6, 2025 17:29
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page--tracking branch from b27218d to a461c6e Compare January 6, 2025 17:58
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page--tracking branch from a461c6e to 8da8bd5 Compare January 6, 2025 19:43
@SuaYoo SuaYoo changed the title wip: Track public collection events feat: Track collection events Jan 7, 2025
@SuaYoo SuaYoo requested review from emma-sg and ikreymer January 7, 2025 00:28
@SuaYoo SuaYoo marked this pull request as ready for review January 7, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg Awaiting requested review from emma-sg

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track public collection views
2 participants
@SuaYoo @emma-sg